Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate url domain for aws metadata urls #1484

Merged
merged 4 commits into from
Nov 3, 2022
Merged

fix: Validate url domain for aws metadata urls #1484

merged 4 commits into from
Nov 3, 2022

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Nov 1, 2022 •
edited
Loading

Updating AWS credential source validation as per new updates in AIP. Make sure the host of url, region_url and imdsv2 session token url belong to AWS metadata server.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 1, 2022
@sai-sunder-s sai-sunder-s marked this pull request as ready for review November 1, 2022 04:04
@sai-sunder-s sai-sunder-s requested review from a team as code owners November 1, 2022 04:04
lsirac
lsirac reviewed Nov 1, 2022
View reviewed changes
src/auth/awsclient.ts Outdated Show resolved Hide resolved
@alexander-fenster alexander-fenster added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@alexander-fenster alexander-fenster merged commit 6dc4e58 into googleapis:main Nov 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2022
@release-please release-please bot mentioned this pull request Nov 3, 2022
Merged
This was referenced Sep 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai-sunder-s @alexander-fenster @lsirac