Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps!: Remove fast-text-encoding as a dependency #1547

Closed
wants to merge 3 commits into from
Closed

deps!: Remove fast-text-encoding as a dependency #1547

wants to merge 3 commits into from

Conversation

ddelgrosso1
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1546 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 16, 2023 14:07
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 16, 2023
@ddelgrosso1
Copy link
Author

Most modern browsers now support this natively. The browsers that do not are generally 6 or more years old.

@ddelgrosso1 ddelgrosso1 added next major: breaking change this is a change that we should wait to bundle into the next major version owlbot:run Add this label to trigger the Owlbot post processor. labels May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 16, 2023
@danielbankhead
Copy link
Contributor

Most modern browsers now support this natively. The browsers that do not are generally 6 or more years old.

Agreed.

@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 5, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: s Pull request size is small. labels Jul 10, 2023
@sofisl sofisl closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: u Pull request is empty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove dep on fast-text-encoder
3 participants
@ddelgrosso1 @danielbankhead @sofisl