Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Nodejs auth library README to point to newer auth instructions #1861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

piaxc
Copy link
Contributor

@piaxc piaxc commented Sep 10, 2024

Remove mention of service account key download and point to correct place for ADC setup.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Remove mention of service account key download and point to correct place for ADC setup.
@piaxc piaxc requested review from a team as code owners September 10, 2024 21:10
Copy link

conventional-commit-lint-gcf bot commented Sep 10, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 10, 2024
@danielbankhead danielbankhead requested a review from a team as a code owner September 27, 2024 01:06
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you update .readme-partials.yaml instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants