Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop support for node.js 4.x #401

Merged
merged 2 commits into from
Jul 2, 2018
Merged

fix: drop support for node.js 4.x #401

merged 2 commits into from
Jul 2, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 1, 2018

BREAKING CHANGE: Node.js 4.x is no longer supported.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2018
@JustinBeckwith JustinBeckwith requested review from ofrobots and a team July 1, 2018 20:23
@codecov-io
Copy link

codecov-io commented Jul 1, 2018

Codecov Report

Merging #401 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #401      +/-   ##
=========================================
- Coverage   94.86%   94.8%   -0.06%     
=========================================
  Files          14      14              
  Lines         974     944      -30     
  Branches      207     219      +12     
=========================================
- Hits          924     895      -29     
+ Misses         50      49       -1
Impacted Files Coverage Δ
src/auth/iam.ts 75% <0%> (-15%) ⬇️
src/auth/googleauth.ts 94.46% <0%> (-0.54%) ⬇️
src/auth/computeclient.ts 95.34% <0%> (-0.11%) ⬇️
src/transporters.ts 95.91% <0%> (-0.09%) ⬇️
src/auth/oauth2client.ts 94.4% <0%> (-0.08%) ⬇️
src/auth/jwtaccess.ts 98.11% <0%> (-0.07%) ⬇️
src/auth/authclient.ts 100% <0%> (ø) ⬆️
src/auth/loginticket.ts 100% <0%> (ø) ⬆️
src/pemverifier.ts 100% <0%> (ø) ⬆️
src/auth/jwtclient.ts 94.84% <0%> (+0.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39aeba1...0de1b99. Read the comment docs.

@ofrobots ofrobots added the semver: major Hint for users that this is an API breaking change. label Jul 2, 2018
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should include 'BREAKING CHANGE' as this is a major. This can be edited at landing time.

LGTM.

@JustinBeckwith JustinBeckwith merged commit fd52f5d into googleapis:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants