Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unhandled rejections by avoid .catch #404

Merged
merged 2 commits into from
Jul 6, 2018
Merged

fix: prevent unhandled rejections by avoid .catch #404

merged 2 commits into from
Jul 6, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 4, 2018

Resolves #403

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2018
@JustinBeckwith JustinBeckwith requested review from ofrobots and a team July 4, 2018 03:00
@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #404 into master will increase coverage by 0.18%.
The diff coverage is 69.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   94.89%   95.07%   +0.18%     
==========================================
  Files          15       15              
  Lines         960      955       -5     
  Branches      218      217       -1     
==========================================
- Hits          911      908       -3     
+ Misses         49       47       -2
Impacted Files Coverage Δ
src/auth/googleauth.ts 94.66% <0%> (ø) ⬆️
src/auth/jwtclient.ts 94.84% <100%> (ø) ⬆️
src/transporters.ts 95.91% <100%> (ø) ⬆️
src/auth/jwtaccess.ts 98.11% <100%> (ø) ⬆️
src/auth/refreshclient.ts 90.69% <100%> (ø) ⬆️
src/auth/oauth2client.ts 94.94% <78.26%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3a57a...27e65cc. Read the comment docs.

@JustinBeckwith JustinBeckwith requested a review from a team July 6, 2018 18:46
@JustinBeckwith JustinBeckwith merged commit d042875 into googleapis:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants