chore: update gcp-metadata for isAvailable fix #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isAvailable` function no longer swallows unexpected errors which means that we can start reporting better errors back to users of this library.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
- Coverage 94.97% 94.87% -0.11%
==========================================
Files 15 15
Lines 956 956
Branches 217 217
==========================================
- Hits 908 907 -1
- Misses 48 49 +1
Continue to review full report at Codecov.
|
| @@ -1021,30 +1017,30 @@ it('_checkIsGCE should not set the _isGCE flag when not running on GCE', | |||
| scope.done(); | |||
| }); | |||
|
|
|||
| it('_checkIsGCE should retry the check for isGCE if it fails the first time', | |||
| it('_checkIsGCE should retry the check for isGCE on transient http errors', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isAvailablefunction no longer swallows unexpected errors whichmeans that we can start reporting better errors back to users of this
library.
Previously #398.