Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gts to the latest version 🚀 #422

Merged
merged 4 commits into from
Jul 17, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jul 12, 2018

Version 0.8.0 of gts was just published.

Dependency gts
Current Version 0.7.1
Type devDependency

The version 0.8.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of gts.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes No esModuleInterop and allowSyntheticDefaultImports

This is a release with breaking changes. We no longer set the esModuleInterop and allowSyntheticDefaultImports in the default TypeScript config. These might be reasonable configurations for end-user application code, but for libraries these can be problematic. TypeScript users of such libraries must have these flags set as well for compilation to succeed. For example: google/google-auth-library-nodejs#381.

There are two ways to deal with this breaking change:

  • (recommended) change code using synthetic imports (import fs from 'fs') back to using old style imports (import * as fs from 'fs').
  • Add "esModuleInterop": true to your local tsconfig.json.

Sorry for the churn.

Commits

Commits

The new version differs by 5 commits.

  • 82ecc4e chore(release): bump version for 0.8.0 (#187)
  • d92f876 fix: also disable allowSyntheticDefaultImports (#184)
  • 94360af fix: disable esModuleInterop (#183)
  • b2b5bbd test: add more tests (#182)
  • 122fe81 fix(init): init package with better main, types (#179)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2018
@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #422   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          15     15           
  Lines         981    981           
  Branches      217    217           
=====================================
  Hits          932    932           
  Misses         49     49
Impacted Files Coverage Δ
src/auth/jwtaccess.ts 98.24% <100%> (ø) ⬆️
src/pemverifier.ts 100% <100%> (ø) ⬆️
src/auth/googleauth.ts 94.28% <100%> (ø) ⬆️
src/auth/oauth2client.ts 94.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b37445...00735b2. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit c9d21e1 into master Jul 17, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/gts-0.8.0 branch July 17, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. greenkeeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants