refactor(deps): use gaxios for HTTP requests instead of axios
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
suggested changes
Jan 15, 2019
JustinBeckwith
approved these changes
Jan 15, 2019
| @@ -950,11 +951,12 @@ it('should not retry requests with streaming data', done => { | |||
| const scope = nock('http://example.com').post('/').reply(401); | |||
| client.credentials = { | |||
| access_token: 'initial-access-token', | |||
| refresh_token: 'refresh-token-placeholder' | |||
| refresh_token: 'refresh-token-placeholder', | |||
| expiry_date: (new Date()).getTime() + 500000 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
changed the title
gaxios for HTTP requests instead of axios
|
Tested with several of the client libs as well. BigQuery, Bigtable, Compute, DNS, Logging, Storage to name a fewveral. |
|
And it worked!? |
|
Yep! And the proxy test script I've been using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from Axios to Gaxios. Hopefully nobody notices.