Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw if there is no refresh token despite the necessity of refreshing #605

Merged
merged 1 commit into from
Jan 27, 2019
Merged

fix: throw if there is no refresh token despite the necessity of refreshing #605

merged 1 commit into from
Jan 27, 2019

Conversation

yuku
Copy link
Contributor

@yuku yuku commented Jan 27, 2019

If OAuth2Client without refresh token has no access token or has an expired access token, OAuth2Client.prototype.getAccessToken should throw an error.

This commit also reduces the number of unreachable code.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

…reshing

If OAuth2Client without refresh token has no access token or
has an expired access token, `OAuth2Client.prototype.getAccessToken`
throws "No refresh token is set." error.

This commit also reduces the number of unreachable code.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 27, 2019
@yuku
Copy link
Contributor Author

yuku commented Jan 27, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 27, 2019
@JustinBeckwith JustinBeckwith changed the title Throw error if there is no refresh token despite the necessity of refreshing fix: throw if there is no refresh token despite the necessity of refreshing Jan 27, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix. This was a total 🤦‍♂️ on my part.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2019
@JustinBeckwith JustinBeckwith merged commit a61dddf into googleapis:master Jan 27, 2019
@yuku yuku deleted the no-refresh-token-error branch February 3, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants