feat: do not deprecate refreshAccessToken #804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #575 @clocked0ne makes a case for it still being useful to be able to call
refreshAccessToken
in some circumstances; e.g., upstream errors our library does not yet take into account, but might be retriable.We recently patched a major issue with refreshing tokens, so it's my expectation that the only reason for calling
refreshAccessToken
would be edge-cases, but I agree with @clocked0ne that it's worth keeping this method available.fixes #575