Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not deprecate refreshAccessToken #804

Merged
merged 3 commits into from
Oct 8, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 8, 2019

In #575 @clocked0ne makes a case for it still being useful to be able to call refreshAccessToken in some circumstances; e.g., upstream errors our library does not yet take into account, but might be retriable.

We recently patched a major issue with refreshing tokens, so it's my expectation that the only reason for calling refreshAccessToken would be edge-cases, but I agree with @clocked0ne that it's worth keeping this method available.

fixes #575

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #804 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   84.34%   84.52%   +0.17%     
==========================================
  Files          17       17              
  Lines         952      950       -2     
  Branches      211      211              
==========================================
  Hits          803      803              
+ Misses         88       87       -1     
+ Partials       61       60       -1
Impacted Files Coverage Δ
src/messages.ts 89.47% <ø> (-0.53%) ⬇️
src/auth/oauth2client.ts 82.72% <ø> (-0.06%) ⬇️
src/auth/googleauth.ts 86.25% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d754771...4b0ec47. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document correct OAuth2 handling of invalid_credentials errors vs deprecated methods
3 participants