Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update tests for PHP 7.4 compatibility #253

Merged
merged 3 commits into from
Dec 18, 2019
Merged

tests: update tests for PHP 7.4 compatibility #253

merged 3 commits into from
Dec 18, 2019

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Nov 8, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
@jdpedrie
Copy link
Contributor Author

@dwsupplee @bshaffer this is ready to go.

bshaffer
bshaffer approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! This must have been a lot of fun to do. Thanks so much for taking care of this!

@jdpedrie
Copy link
Contributor Author

@bshaffer this one was fine. GAX on the other hand....

@jdpedrie jdpedrie merged commit 207925e into googleapis:master Dec 18, 2019
@jdpedrie jdpedrie deleted the update-tests branch December 18, 2019 22:28
@bshaffer bshaffer mentioned this pull request Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpedrie @bshaffer @googlebot