Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add version in composer #500

Closed
wants to merge 1 commit into from
Closed

chore: Add version in composer #500

wants to merge 1 commit into from

Conversation

yash30201
Copy link
Contributor

release-please bot updates CHANGELOG.md and composer.json with every release (code pointer). Right now auth library's composer.json doesn't has any version key-value pair.

Manually adding a version in composer ensures release-please updates it with every release.

@yash30201 yash30201 requested a review from a team as a code owner December 4, 2023 13:46
bshaffer
bshaffer reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use the VERSION file (as we do in all our subrepos) as opposed to conflating this with composer.json. See here for an example for why this isn't encouraged.

@yash30201
Copy link
Contributor Author

Closing as googleapis/release-please#2153 would allow updation of VERSION file which is more appropriate for the use case.

@yash30201 yash30201 closed this Dec 5, 2023
@yash30201 yash30201 deleted the add-version-in-composer branch December 5, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash30201 @bshaffer