Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Version File #501

Merged
merged 1 commit into from
Dec 12, 2023
Merged

chore: Add Version File #501

merged 1 commit into from
Dec 12, 2023

Conversation

yash30201
Copy link
Contributor

Adding a VERSION file so that with feat googleapis/release-please#2153, release-please bot starts updating the version in VERSION.

@yash30201 yash30201 requested a review from a team as a code owner December 5, 2023 09:27
@yash30201 yash30201 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2023
@bshaffer
Copy link
Contributor

bshaffer commented Dec 12, 2023

@yash30201 why is this marked as Do Not Merge?

@yash30201 yash30201 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 12, 2023
@yash30201
Copy link
Contributor Author

@yash30201 why is this marked as Do Not Merge?

I put it here so we merge this only after googleapis/release-please#2153 get's merged. Since it's done so we're good to go now.

@yash30201 yash30201 merged commit 7b03c82 into main Dec 12, 2023
13 checks passed
@yash30201 yash30201 deleted the add-version-file branch December 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants