fix: lint error from new phpseclib #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
added
the
release blocking
ajupazhamayil
previously approved these changes
Jan 3, 2024
|
This is already being covered here: #513 |
|
Removing approval here as I am not sure which PR will be merged.. both look the same to me.. Thank you! |
ajupazhamayil
requested review from
ajupazhamayil
and removed request for
ajupazhamayil
ajupazhamayil
dismissed
their stale review
Not sure this PR will be merged or the other one pointed out in this PR.
That PR is addressing two issues in one, and also the fix is not the same as I've implemented (there's an exception being thrown for If you'd like to split the fix out into a separate PR and remove the other exception being thrown, I'm happy to approve it and merge it, but we shouldn't put two different things in a single PR. |
|
We can close this.. I am splitting this PR: #513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a linting error caused in the latest version (3.0.35) of PHPSeclib due to the
AsymmetricKey::toStringfunction having its return type changed fromstringtostring|array