local server bind address

[gilesknap]

This PR adds the bind_addr parameter to run_local_server. When using localhost inside of a container this is needed to allow the redirect server to bind to an address to which response will return. In a container this address is not the same as the host address of localhost.

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #201 🦕

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[gilesknap]

This should also fix #87

[gilesknap]

Hi @arithmetic1728 do I need to do anything else to get this PR approved? Thanks.

[petethegreat]

hi @gilesknap,
Was just wondering if anything is happening with this - we run jupyterlab out of a docker container, so I believe this PR would allow us to solve some of the issues we're facing.
Thanks!

[gilesknap]

@petethegreat, sorry but nobody from Google is responding to this PR.

However the good news is I have released a container with this fix in it by building it against my fork of this repo. I just can't release that to Pypi as non-pypi dependencies are not allowed there.

Try out docker pull gilesknap/gphotos-sync:3.04

Drop me an issue here if this does not work for you https://github.com/gilesknap/gphotos-sync/issues

EDIT: @petethegreat I just realised that the above is not good news for you since you need the fix here, not my project! But it now looks like the PR is progressing.

[clundin25]

@gilesknap sorry for the delay in responding to this. This change looks great, I have a few nits and after that we can get this merged.

[clundin25]

Can you you squash your commits and rebase to main in order to get past the conventional commits check?

[gilesknap]

Thanks @clundin25 I believe everything is in order now,

[clundin25]

@gilesknap looks like the linter is complaining. Do you mind running nox -s blacken?

[gilesknap]

sorry about that. The commit is now black verified.

[clundin25]

@gilesknap Seems your re-format may not have pushed. Can you try rebasing and running the formatter again?

Sorry for the inconvenience

[gilesknap]

That was my bad. I have now confirmed that the reformat is showing in the commit.

[clundin25]

Thank you for the contribution Giles!

[petethegreat]

Excellent! Thanks @gilesknap and @clundin25 !