Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added py.typed to MANIFEST.in #1526

Merged
merged 5 commits into from
Jun 27, 2024
Merged

fix: Added py.typed to MANIFEST.in #1526

merged 5 commits into from
Jun 27, 2024

Conversation

jamesbraza
Copy link
Contributor

Adds py.typed to package metadata

@jamesbraza jamesbraza requested review from a team as code owners May 22, 2024 05:30
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@jamesbraza jamesbraza changed the title Added py.typed to MANIFEST.in Added py.typed to MANIFEST.in May 22, 2024
@clundin25 clundin25 changed the title Added py.typed to MANIFEST.in chore: Added py.typed to MANIFEST.in Jun 27, 2024
@clundin25 clundin25 requested a review from parthea June 27, 2024 16:03
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @jamesbraza !

As per https://mypy.readthedocs.io/en/latest/installed_packages.html#creating-pep-561-compatible-packages, we still need the changes to MANIFEST.in for the .tar.gz archive

The instructions above are enough to ensure that the built wheels contain the appropriate files.
However, to ensure inclusion inside the sdist (.tar.gz archive), you may also need to modify the inclusion rules in your MANIFEST.in:

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2024
@jamesbraza
Copy link
Contributor Author

@parthea thanks for sharing that mypy docs link, nice find. It looks like @clundin25 added back in the py.typed to MANIFEST.in, so this PR should be good to go

@parthea parthea changed the title chore: Added py.typed to MANIFEST.in fix: Added py.typed to MANIFEST.in Jun 27, 2024
@parthea parthea merged commit 1829a3b into googleapis:main Jun 27, 2024
14 checks passed
@jamesbraza jamesbraza deleted the adding-py-typed branch June 27, 2024 18:30
@pietrodn
Copy link
Contributor

This PR unfortunately didn't fix the issue, which is still there in version 2.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py.typed marker is missing Bundle py.typed files with package
5 participants