-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added py.typed to MANIFEST.in #1526
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
py.typed
to MANIFEST.in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @jamesbraza !
As per https://mypy.readthedocs.io/en/latest/installed_packages.html#creating-pep-561-compatible-packages, we still need the changes to MANIFEST.in
for the .tar.gz
archive
The instructions above are enough to ensure that the built wheels contain the appropriate files.
However, to ensure inclusion inside the sdist (.tar.gz archive), you may also need to modify the inclusion rules in your MANIFEST.in:
@parthea thanks for sharing that |
This PR unfortunately didn't fix the issue, which is still there in version 2.34.0. |
Adds
py.typed
to package metadata