Skip to content

fix: fix type error in credentials.py for python 3.7 and 3.8 #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

fix: fix type error in credentials.py for python 3.7 and 3.8 #1805

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6ffad0
fix: fix type error in credentials.py for python 3.7 and 3.8
nbayati Aug 14, 2025
0f50603
fix linting error
nbayati Aug 14, 2025
3172f4b
Merge branch 'main' into fix/support-older-python-versions
nbayati Aug 14, 2025
fa467b3
Merge branch 'main' into fix/support-older-python-versions
nbayati Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions google/auth/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import abc
from enum import Enum
import os
from typing import List

from google.auth import _helpers, environment_vars
from google.auth import exceptions
Expand All @@ -27,7 +28,7 @@
from google.auth._refresh_worker import RefreshThreadManager

DEFAULT_UNIVERSE_DOMAIN = "googleapis.com"
NO_OP_TRUST_BOUNDARY_LOCATIONS: list[str] = []
NO_OP_TRUST_BOUNDARY_LOCATIONS: List[str] = []
NO_OP_TRUST_BOUNDARY_ENCODED_LOCATIONS = "0x0"


Expand Down Expand Up @@ -434,13 +435,12 @@ def _build_trust_boundary_lookup_url(self):
def _has_no_op_trust_boundary(self):
# A no-op trust boundary is indicated by encodedLocations being "0x0".
# The "locations" list may or may not be present as an empty list.
if (
self._trust_boundary is not None
and self._trust_boundary["encodedLocations"]
if self._trust_boundary is None:
return False
return (
self._trust_boundary.get("encodedLocations")
== NO_OP_TRUST_BOUNDARY_ENCODED_LOCATIONS
):
return True
return False
)


class AnonymousCredentials(Credentials):
Expand Down