fix: propagate #1809 to oauth.Credentials
#1875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeedjones
changed the title
mikeedjones
changed the title
oauth.Credentials
…d add _refresh_token wrapper Rename the stored refresh token attribute from _refresh_token to _refresh_token_val to avoid a name collision with a newly added _refresh_token(request) wrapper that delegates to refresh(request). Update all references and tests accordingly to match changes in fix test_aws_based_external_account system test Fixes googleapis#1850
…te, as opposed to a methdo
mikeedjones
force-pushed
the
bugfix/propagate-change-of-refresh-token-to-oauth-credentials
branch
from
a5b9161 to
bec5843
Compare
mikeedjones
commented
Nov 23, 2025
| ) | ||
| self.token = None | ||
| self._refresh_token = None | ||
| self._refresh_token_val = None |
Author
There was a problem hiding this comment.
I think this and the associated test was missed in #1809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1850
#1809 changed
_refresh_tokenonauth.Credentialsbut notoauth2.Credentialswhich are used interchangeably in other google SKDs. This PR propagates the same changes as in #1809 tooauth.Credentials