chore: prevent normalization of semver versioning #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
parthea
previously approved these changes
Apr 16, 2021
parthea
reviewed
Apr 16, 2021
| except ImportError: | ||
| # setuptools <39.0.0 uses packaging from pkg_resources.extern | ||
| from pkg_resources.extern import packaging | ||
| packaging.version.Version = packaging.version.LegacyVersion |
Contributor
There was a problem hiding this comment.
Instead of the workaround, let's bump the setuptools version since it's a dependency.
https://github.com/googleapis/google-auth-library-python/blob/master/setup.py#L29
Contributor
Author
There was a problem hiding this comment.
I tried doing that, it works for Python3 but does not work for Python2 :(
Contributor
There was a problem hiding this comment.
Ah it must be from setuptools removing support for Python 2. This LGTM.
busunkim96
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from
-patchto.patchwhich is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.