feat: Use google-cloud-env for more robust Metadata Service access #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2023
bajajneha27
approved these changes
Dec 4, 2023
dazuma
requested review from
viacheslav-rostovtsev
and removed request for
viacheslav-rostovtsev
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for proper universe_domain support. It removes the code that makes direct calls to the Metadata Server (to determine GCE residence and to fetch Metadata-provided access tokens), and instead delegates to the more robust code in the google-cloud-env 2.0 gem.
Also drops support for Ruby 2.6 since google-cloud-env 2.0 also drops Ruby 2.6.
Also closes #444.