Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include universe_domain in credentials #460

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Dec 1, 2023

Implements the auth requirements for Universe Domain support. Specifically:

  • Added a universe_domain attr_accessor to all credentials classes. This was added to the signet monkeypatch for signet-based credentials, to ExternalAccount::BaseCredentials for all the external credential types, and to Googleauth::Credentials as a delegator to the underlying signet client.
  • GCECredentials obtains the universe_domain value by looking up the Metadata value
  • ExternalAccount types populate the value from the input hash
  • JsonKeyReader based credentials (such as ServiceAccount) get the value from the input file.
  • Altered the logic for determining whether to use JWT to ensure that JWT is used on non-Google universes.

@dazuma dazuma force-pushed the pr/universe-domain branch 2 times, most recently from e33c8ad to bb63cef Compare December 2, 2023 23:37
@dazuma dazuma marked this pull request as ready for review December 3, 2023 00:02
@dazuma dazuma requested a review from a team as a code owner December 3, 2023 00:02
@dazuma dazuma merged commit a7ff57b into googleapis:main Dec 7, 2023
11 checks passed
@dazuma dazuma deleted the pr/universe-domain branch December 12, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants