This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: complete test coverage for g:c:spanner::Timestamp #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test cases for some previously unexercised code paths * Remove one always-unreachable overflow-detection code path * Another overflow-detection code path is unreachable when tm_year is only 32-bits (which is usually the case), so we can't hit 100% coverage * Fix one bug with creating a `Timestamp` from a `time_point` with sub-nanosecond precision, and add test case.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 95.63% 95.69% +0.06%
==========================================
Files 175 175
Lines 13570 13598 +28
==========================================
+ Hits 12977 13012 +35
+ Misses 593 586 -7
Continue to review full report at Codecov.
|
coryan
approved these changes
Jan 11, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…ogle-cloud-cpp-spanner#1190) * Add test cases for some previously unexercised code paths * Remove one always-unreachable overflow-detection code path * Another overflow-detection code path is unreachable when tm_year is only 32-bits (which is usually the case), so we can't hit 100% coverage * Fix one bug with creating a `Timestamp` from a `time_point` with sub-nanosecond precision, and add test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tm_yearis only 32-bits (which is usually the case), so wecan't hit 100% coverage
Timestampfrom atime_pointwith sub-nanosecond precision, and add test case.
This change is