Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove pubsub configuration classes and methods that predated Options #7348

Closed
dbolduc opened this issue Sep 23, 2021 · 0 comments · Fixed by #8916
Closed

Deprecate and remove pubsub configuration classes and methods that predated Options #7348

dbolduc opened this issue Sep 23, 2021 · 0 comments · Fixed by #8916
Assignees
@coryan
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented Sep 23, 2021

basically #6642, but in pubsub.

With #6306 implemented, we can start to deprecate PublisherOptions and SubscriberOptions, as they are no longer needed or wanted.
@dbolduc dbolduc added the type: cleanup An internal cleanup or hygiene concern. label Sep 23, 2021
@dbolduc dbolduc changed the title Deprecate and remove pubsub Make*Connection functions that are not configured with Options Deprecate and remove pubsub configuration classes and methods that predated Options Sep 23, 2021
@dbolduc dbolduc mentioned this issue Sep 23, 2021
Merged
@coryan coryan self-assigned this Apr 28, 2022
@coryan coryan added the api: pubsub Issues related to the Pub/Sub API. label May 6, 2022
This was referenced May 6, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc(pubsub): deprecate SubscriberOptions coryan/google-cloud-cpp
2 participants
@coryan @dbolduc