Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert google/cloud/pubsub to use g::c::Options #6306

Closed
coryan opened this issue Apr 21, 2021 · 0 comments · Fixed by #7350
Closed

Convert google/cloud/pubsub to use g::c::Options #6306

coryan opened this issue Apr 21, 2021 · 0 comments · Fixed by #7350
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
GUAC M2: use unif...

Comments

@coryan
Copy link
Contributor

coryan commented Apr 21, 2021

Change the library to prefer google::cloud::Options in its initialization, the overloads taking google::cloud::pubsub::ClientOptions should remain usable for backwards compatibility.
@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 21, 2021
@coryan coryan added this to the Unified Auth Client for C++ milestone Apr 21, 2021
This was referenced Sep 1, 2021
Closed
Closed
This was referenced Sep 15, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 23, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
GUAC M2: use unified credentials in e...
Development

Successfully merging a pull request may close this issue.

cleanup(pubsub): remove unused code; tidy up other code; edit documentation dbolduc/google-cloud-cpp
1 participant
@coryan