feat(pubsub): add policy options; default common options #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7335 +/- ##
========================================
Coverage 93.66% 93.67%
========================================
Files 1352 1352
Lines 116986 117092 +106
========================================
+ Hits 109573 109682 +109
+ Misses 7413 7410 -3
Continue to review full report at Codecov.
|
devbww
approved these changes
Sep 20, 2021
Comment on lines
+44
to
+48
| auto emulator = internal::GetEnv("PUBSUB_EMULATOR_HOST"); | ||
| if (emulator.has_value()) { | ||
| opts.set<EndpointOption>(*emulator).set<GrpcCredentialOption>( | ||
| grpc::InsecureChannelCredentials()); | ||
| } |
There was a problem hiding this comment.
Perhaps move this next to the other setting for GrpcCredentialOption?
There was a problem hiding this comment.
the EndpointOptions are colocated 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #6306
This change may seem strange on its own, because the code it is "replacing" is not touched in this PR. I did this because the full change is too large, and I want the PR's to be manageable. A (somewhat accurate) draft of the bigger picture can be found here.
Here are the sources for the default values:
PUBSUB_EMULATOR_HOSTcomes frominternal/emulator_overrides*which will eventually be removed.GrpcOptionListandCommonOptionListcome from: connection_options.cc, except forGrpcBackgroundThreadPoolSizeOptionwhich comes from here (publisher) and here(subscriber)PolicyOptionListcome from: here (publisher) and here (subscriber)** (Note the special retry policy for the subscriber)This change is