Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): move to storage_internal #10012

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 10, 2022

Specifically HybridClient.

Part of the work for #8929


This change is Reviewable

Specifically `HybridClient`.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 89e1cee722e41f268a0f03933be2e9031eeb1744

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review October 10, 2022 20:10
@coryan coryan requested a review from a team as a code owner October 10, 2022 20:10
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 94.23% // Head: 94.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (89e1cee) compared to base (6580ede).
Patch coverage: 95.08% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10012   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files        1522     1522           
  Lines      141370   141373    +3     
=======================================
+ Hits       133214   133223    +9     
+ Misses       8156     8150    -6     
Impacted Files Coverage Δ
google/cloud/storage/grpc_plugin_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/hybrid_client.h 100.00% <ø> (ø)
google/cloud/storage/internal/hybrid_client.cc 94.06% <94.82%> (+0.10%) ⬆️
google/cloud/storage/grpc_plugin.cc 100.00% <100.00%> (ø)
...loud/storage/internal/grpc_client_failures_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/storage/parallel_upload.cc 98.61% <0.00%> (+0.34%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.50%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.31% <0.00%> (+0.56%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan merged commit 31b85f1 into googleapis:main Oct 10, 2022
@coryan coryan deleted the cleanup-GCS+gRPC-move-HybridClient branch October 10, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants