Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): move to storage_internal #10015

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 10, 2022

Specifically GrpcClient.

Part of the work for #8929


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3701e9294794c56085933515dda38d83d22de1b4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan changed the title cleanup(GCS+gRP): move to storage_internal cleanup(GCS+gRPC): move to storage_internal Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 94.23% // Head: 94.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3701e92) compared to base (d4f61ad).
Patch coverage: 98.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10015   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files        1522     1522           
  Lines      141361   141379   +18     
=======================================
+ Hits       133212   133230   +18     
  Misses       8149     8149           
Impacted Files Coverage Δ
google/cloud/storage/grpc_plugin_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
...e/internal/grpc_client_insert_object_media_test.cc 100.00% <ø> (ø)
...d/storage/internal/grpc_client_read_object_test.cc 96.77% <ø> (ø)
.../storage/internal/grpc_client_upload_chunk_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.cc 98.81% <97.29%> (+<0.01%) ⬆️
google/cloud/storage/async_client.cc 100.00% <100.00%> (ø)
google/cloud/storage/grpc_plugin.cc 100.00% <100.00%> (ø)
...le/cloud/storage/internal/async_connection_impl.cc 91.66% <100.00%> (ø)
...oud/storage/internal/async_connection_impl_test.cc 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 10, 2022 23:53
@coryan coryan requested a review from a team as a code owner October 10, 2022 23:53
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 2f412fe into googleapis:main Oct 11, 2022
@coryan coryan deleted the cleanup-GCS+gRPC-move-GrpcClient branch October 11, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants