Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added -GNinja to cmake configuration commands #10532

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jan 10, 2023

docs: Also fixed the directory name for clang example


This change is Reviewable

docs: Also fixed the directory name for clang example
@tmatsuo tmatsuo requested a review from a team as a code owner January 10, 2023 00:46
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 93.97% // Head: 93.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (002c9dd) compared to base (c409811).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10532      +/-   ##
==========================================
- Coverage   93.97%   93.97%   -0.01%     
==========================================
  Files        1630     1630              
  Lines      147027   147027              
==========================================
- Hits       138170   138167       -3     
- Misses       8857     8860       +3     
Impacted Files Coverage Δ
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-0.34%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.85% <0.00%> (-0.08%) ⬇️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jan 10, 2023

@coryan Thanks, PTAL

@tmatsuo tmatsuo enabled auto-merge (squash) January 10, 2023 17:25
@tmatsuo tmatsuo merged commit d19290d into main Jan 10, 2023
@tmatsuo tmatsuo deleted the tmatsuo-patch-1 branch January 10, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants