Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigtable): clean up CreateTable sample #10844

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 16, 2023

The bigtable_hw_create_table region cares about making a CreateTable rpc, not creating a Table client.


This change is Reviewable

@dbolduc dbolduc requested a review from a team as a code owner February 16, 2023 06:47
@product-auto-label product-auto-label bot added api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples. labels Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 93.66% // Head: 93.65% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0232bed) compared to base (fb18335).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10844      +/-   ##
==========================================
- Coverage   93.66%   93.65%   -0.01%     
==========================================
  Files        1715     1715              
  Lines      154214   154214              
==========================================
- Hits       144438   144436       -2     
- Misses       9776     9778       +2     
Impacted Files Coverage Δ
...le/cloud/bigtable/examples/bigtable_hello_world.cc 90.90% <100.00%> (ø)
google/cloud/internal/timer_queue.cc 96.10% <0.00%> (-1.30%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 86.94% <0.00%> (-0.15%) ⬇️
google/cloud/completion_queue_test.cc 97.32% <0.00%> (+0.19%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 88.96% <0.00%> (+0.33%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc merged commit 1f82d62 into googleapis:main Feb 16, 2023
@dbolduc dbolduc deleted the bigtable-hw-samples branch February 16, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants