doc(spanner): mark obsolete Spanner options classes as deprecated #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the `spanner::${foo}Options` classes that are only used in the
backwards-compatibility `spanner::Client` functions as deprecated.
List the "Options" types that should be used in their place.
Note: These are still also used when mocking a `spanner::Connection`.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #12256 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 2009 2009
Lines 177126 177126
=======================================
Hits 165837 165837
Misses 11289 11289
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the
spanner::${foo}Optionsclasses that are only used in the backwards-compatibilityspanner::Clientfunctions as deprecated. List the "Options" types that should be used in their place.Note: These are still also used when mocking a
spanner::Connection.This change is