Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): split discovery doc output #12866

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 10, 2023

Sometimes we need the *_proto_export.h files to go to a different directory vs. the *.proto files.

Part of the work for #12854


This change is Reviewable

Sometimes we need the `*_proto_export.h` files to go to a different
directory vs. the `*.proto` files.
@coryan coryan temporarily deployed to internal October 10, 2023 21:07 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review October 10, 2023 21:15
@coryan coryan requested a review from a team as a code owner October 10, 2023 21:15
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan enabled auto-merge (squash) October 10, 2023 21:25
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7ca8d05) 93.54% compared to head (4b173e7) 93.54%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12866      +/-   ##
==========================================
- Coverage   93.54%   93.54%   -0.01%     
==========================================
  Files        2075     2075              
  Lines      180676   180677       +1     
==========================================
  Hits       169016   169016              
- Misses      11660    11661       +1     
Files Coverage Δ
generator/internal/discovery_to_proto_test.cc 100.00% <100.00%> (ø)
generator/internal/discovery_to_proto.cc 82.65% <60.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit 951ee05 into googleapis:main Oct 10, 2023
@coryan coryan deleted the feat-generator-different-output-path-for-exports branch October 10, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants