fix(spanner): delete idle sessions upon SessionPool destruction #14012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send a fire-and-forget `AsyncDeleteSession()` request for all idle sessions during `~SessionPool()`. Previously they would have continued to exist in the service until garbage collected due to inactivity after 60 minutes. Add expectations for these requests in the connection/session_pool unit tests.
coryan
approved these changes
Apr 17, 2024
| for (auto const& session : sessions_) { | ||
| if (session->is_bad()) continue; | ||
| AsyncDeleteSession(cq_, session->channel()->stub, session->session_name()) | ||
| .then([](auto result) { auto status = result.get(); }); |
There was a problem hiding this comment.
Is the .then() really needed?
There was a problem hiding this comment.
No, I don't believe so, but I thought it made things a little clearer, particularly if we later to chose to do any logging/tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a fire-and-forget
AsyncDeleteSession()request for all idle sessions during~SessionPool(). Previously they would have continued to exist in the service until garbage collected due to inactivity after 60 minutes.Add expectations for these requests in the connection/session_pool unit tests.
This change is