Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): do not reference repo name #14287

Merged
merged 1 commit into from
May 29, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented May 29, 2024

Dependents may give our repo any name. We should not be referencing our own project's name.

Bug introduced as part of #14173

To make the changes, I ran:

sed -i "s;@google_cloud_cpp//bazel:gapic.bzl;//bazel:gapic.bzl;" $(git ls-files)

This change is Reviewable

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (146cf3c) to head (b2b1c49).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14287      +/-   ##
==========================================
+ Coverage   93.24%   93.79%   +0.55%     
==========================================
  Files        2214     2301      +87     
  Lines      193630   204402   +10772     
==========================================
+ Hits       180550   191727   +11177     
+ Misses      13080    12675     -405     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review May 29, 2024 21:19
@dbolduc dbolduc requested review from a team as code owners May 29, 2024 21:19
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 127 of 127 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 6bbe7cb into googleapis:main May 29, 2024
64 checks passed
@dbolduc dbolduc deleted the fix-bazel-gapic-bzl branch May 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants