Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Use googleapis from the Bazel Central Registry. #14771

Closed
wants to merge 1 commit into from

Conversation

ryanli
Copy link
Contributor

@ryanli ryanli commented Oct 7, 2024

Most of the patches are already present in the BCR module.


This change is Reviewable

Most of the patches are already present in the BCR module.
@ryanli ryanli requested a review from a team as a code owner October 7, 2024 15:15
@dbolduc
Copy link
Member

dbolduc commented Oct 7, 2024

/gcbrun

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good cleanup, but I am not sure we want to wait for BCR in order to update the commit SHA of googleapis we are pinned to.

module_name = "googleapis",
integrity = "sha256-qfsB7M2N7tXY0blSHgIgq8/yUc0Kskid9Zk8H3OS5nc=",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we already updated googleapis to a more recent version than is in BCR. And generated code based on the newer protos.

@ryanli
Copy link
Contributor Author

ryanli commented Oct 9, 2024

This seems like a good cleanup, but I am not sure we want to wait for BCR in order to update the commit SHA of googleapis we are pinned to.

Thanks, I guess this is also why some of the tests are failing. Let me close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants