Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API key authentication #14779

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 10, 2024

Part of the work for #14759

Introduce a dedicated API for authenticating with API keys.

Update the sample because it doubles as an integration test.


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review October 10, 2024 19:38
@dbolduc dbolduc requested a review from a team as a code owner October 10, 2024 19:38
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (db36db3) to head (2b6d26e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14779   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files        2317     2317           
  Lines      208162   208171    +9     
=======================================
+ Hits       194157   194174   +17     
+ Misses      14005    13997    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 67b10ea into googleapis:main Oct 10, 2024
75 checks passed
@dbolduc dbolduc deleted the feat-api-key-creds branch October 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants