Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): better suggestion for deprecated API #14786

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 14, 2024

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 14, 2024
@dbolduc dbolduc marked this pull request as ready for review October 14, 2024 19:47
@dbolduc dbolduc requested review from a team as code owners October 14, 2024 19:47
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (8abc170) to head (2a2aa8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14786   +/-   ##
=======================================
  Coverage   93.27%   93.28%           
=======================================
  Files        2319     2319           
  Lines      208231   208231           
=======================================
+ Hits       194228   194238   +10     
+ Misses      14003    13993   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 80a518a into googleapis:main Oct 14, 2024
74 checks passed
@dbolduc dbolduc deleted the docs-storage-ca-roots-path branch October 14, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants