-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(generator): handle deprecated services #14849
impl(generator): handle deprecated services #14849
Conversation
ec3bc37
to
d844d6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run, I think we want to deprecate these clients. As in GOOGLE_CLOUD_CPP_DEPRECATED(...)
.
@@ -237,13 +237,19 @@ class ServiceCodeGenerator : public GeneratorInterface { | |||
|
|||
std::vector<MixinMethod> const& MixinMethods() const; | |||
|
|||
/** | |||
* If the service is defined with `option deprecated = true;`. | |||
* @return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I went ahead an added it to the generated Client.
Reviewable status: 0 of 113 files reviewed, all discussions resolved (waiting on @dbolduc)
@@ -237,13 +237,19 @@ class ServiceCodeGenerator : public GeneratorInterface { | |||
|
|||
std::vector<MixinMethod> const& MixinMethods() const; | |||
|
|||
/** | |||
* If the service is defined with `option deprecated = true;`. | |||
* @return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
v29 of protobuf adds
[[deprecated]]
attributes to proto message types generated from deprecated services. We need to disable compiler warnings on these types because of-Werror
until we remove the deprecated services.This change is