feat(common): add ability to supply a user-run CQ to gRPC options #7354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7346
I went with
GrpcCompletionQueueOption
as the name.I went with
GrpcCompletionQueueOption
>GrpcBackgroundThreadsFactoryOption
>GrpcBackgroundThreadPoolSizeOption
. (I put the CQ option first in case we ever deprecate the factory option.)For testing the precedence, we have
a > b > c
so I just checked thata > b && b > c
I did not propagate the test for the option into things like Spanner, which tests other options from
GrpcOptionList
. We should think about how to test common options that show up in all of our libraries. Do we want to duplicate a common test N times? maybe.Bigtable's
client_options_test.cc
should always have been using theMakeBackgroundThreadsFactory(opts)
method instead of checking the option.This change is