Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bigtable): add documentation for no automatic channel refresh #7373

Merged
merged 1 commit into from
Sep 29, 2021
Merged

docs(bigtable): add documentation for no automatic channel refresh #7373

merged 1 commit into from
Sep 29, 2021

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 29, 2021 •
edited by coryan
Loading

Just making a note in the documentation for this behavior:

google-cloud-cpp/google/cloud/bigtable/internal/common_client.h

Lines 220 to 222 in 113dc99

if (opts_.get<MaxConnectionRefreshOption>().count() == 0) {
return res;
}

This change is Reviewable

@dbolduc dbolduc requested a review from a team as a code owner September 29, 2021 14:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Sep 29, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3e59063796e9f00428f73cca9831736dd7792f19

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit 9159df5 into googleapis:main Sep 29, 2021
@dbolduc dbolduc deleted the bigtable-conn-refresh-doc branch September 29, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbolduc @google-cloud-cpp-bot @coryan @googlebot