Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(storage): label ClientOptions as deprecated #7511

Merged
merged 1 commit into from
Oct 22, 2021
Merged

doc(storage): label ClientOptions as deprecated #7511

merged 1 commit into from
Oct 22, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 22, 2021 •
edited
Loading

Also took the opportunity to link the *Option classes corresponding to
each (deprecated) member function, because the new classes have much
better documentation.

Motivated by #7505

This change is Reviewable

@coryan
doc(storage): label ClientOptions as deprecated
444e91e 
Also took the opportunity to link the `*Option` classes corresponding to
each (deprecated) member function, because the new classes have much
better documentation.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 22, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 444e91eaa4558de5a9a72faf3407826e63d7b802

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #7511 (444e91e) into main (7904f0f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7511   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1361     1361           
  Lines      118122   118122           
=======================================
+ Hits       110618   110619    +1     
+ Misses       7504     7503    -1
Impacted Files Coverage Δ
google/cloud/storage/client_options.h 100.00% <ø> (ø)
...integration_tests/schema_admin_integration_test.cc 98.85% <0.00%> (-1.15%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.60% <0.00%> (+0.59%) ⬆️
google/cloud/bigtable/internal/common_client.cc 100.00% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7904f0f...444e91e. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 22, 2021 20:35
@coryan coryan requested a review from a team as a code owner October 22, 2021 20:35
@coryan coryan merged commit 10c28c1 into googleapis:main Oct 22, 2021
@coryan coryan deleted the doc-storage-label-client-options-as-deprecated branch October 22, 2021 21:21
@dbolduc
Copy link
Member

dbolduc commented Oct 23, 2021

part of the work for #6642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coryan @google-cloud-cpp-bot @dbolduc @devbww @googlebot