feat(common): add tracing for the LRO polling loop #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get a little visibility into the LRO polling loop in the tracing log, most notably to see how long we are waiting between polls. Part of googleapis#7562. The issue looks important, and after failing to diagnose the problem from the two occurrences we've seen so far, and failing to reproduce it, the next best thing is to try to get a little bit more data when it happens again. And also to that end, add a timestamp to the beginning of each of the Spanner samples.
google-cla
bot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7615 +/- ##
==========================================
+ Coverage 95.25% 95.26% +0.01%
==========================================
Files 1254 1254
Lines 113231 113201 -30
==========================================
- Hits 107857 107845 -12
+ Misses 5374 5356 -18
Continue to review full report at Codecov.
|
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get a little visibility into the LRO polling loop in the tracing
log, most notably to see how long we are waiting between polls.
Part of #7562. The issue looks important, and after failing to
diagnose the problem from the two occurrences we've seen so far,
and failing to reproduce it, the next best thing is to try to
get a little bit more data when it happens again.
And also to that end, add a timestamp to the beginning of each
of the Spanner samples.
This change is