Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(storage): simplify one of the unit tests #7857

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 9, 2022

The unit test for storage::RetryResumableUploadSession gets shorter
and more readable if one uses the googlemock features for verifying
things happen in a certain sequence.

Part of the work for #7835


This change is Reviewable

The unit test for `storage::RetryResumableUploadSession` gets shorter
and more readable if one uses the googlemock features for verifying
things happen in a certain sequence.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 9, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0fc2b79af6e7cd578fb8d6dfddf906f2e259e873

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #7857 (b7e2e67) into main (19b7ec7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7857      +/-   ##
==========================================
- Coverage   95.12%   95.11%   -0.02%     
==========================================
  Files        1284     1284              
  Lines      116200   115986     -214     
==========================================
- Hits       110539   110322     -217     
- Misses       5661     5664       +3     
Impacted Files Coverage Δ
google/cloud/storage/client_write_object_test.cc 100.00% <ø> (ø)
...ge/internal/retry_resumable_upload_session_test.cc 99.58% <100.00%> (-0.11%) ⬇️
...storage/internal/retry_resumable_upload_session.cc 99.08% <0.00%> (-0.92%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
google/cloud/storage/client.cc 86.58% <0.00%> (-0.64%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 90.10% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b7ec7...b7e2e67. Read the comment docs.

@coryan coryan marked this pull request as ready for review January 9, 2022 16:16
@coryan coryan requested a review from a team as a code owner January 9, 2022 16:16
@coryan coryan enabled auto-merge (squash) January 9, 2022 16:16
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e6a45307e90589acd6cbb38f020615b9b93dd7a4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b7e2e67b121a6c3dd60e0f5f15c97bb61752d98f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit bb8ed0b into googleapis:main Jan 10, 2022
@coryan coryan deleted the cleanup-storage-simplify-retry-resumable-session-test branch January 10, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants