-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(storage): simplify one of the unit tests #7857
cleanup(storage): simplify one of the unit tests #7857
Conversation
The unit test for `storage::RetryResumableUploadSession` gets shorter and more readable if one uses the googlemock features for verifying things happen in a certain sequence.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7857 +/- ##
==========================================
- Coverage 95.12% 95.11% -0.02%
==========================================
Files 1284 1284
Lines 116200 115986 -214
==========================================
- Hits 110539 110322 -217
- Misses 5661 5664 +3
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
The unit test for
storage::RetryResumableUploadSession
gets shorterand more readable if one uses the googlemock features for verifying
things happen in a certain sequence.
Part of the work for #7835
This change is