Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): per-call options in TopicAdminClient #8411

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 18, 2022

Part of the work for #7689


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 18, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6dd7bdaff44f749057664f663a7db291b2d69a10

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8411 (a2f09d0) into main (d6e0897) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8411      +/-   ##
==========================================
- Coverage   95.04%   95.04%   -0.01%     
==========================================
  Files        1363     1364       +1     
  Lines      121304   121335      +31     
==========================================
+ Hits       115290   115317      +27     
- Misses       6014     6018       +4     
Impacted Files Coverage Δ
google/cloud/pubsub/topic_admin_client.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/topic_admin_client.h 100.00% <100.00%> (ø)
google/cloud/pubsub/topic_admin_client_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/topic_admin_connection.cc 85.39% <100.00%> (+0.50%) ⬆️
google/cloud/pubsub/topic_admin_connection.h 100.00% <100.00%> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 48.38% <0.00%> (-12.91%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.24%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e0897...a2f09d0. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a2f09d04f2a906fbc762b6cf7014d50bd1219c59

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review February 18, 2022 16:51
@coryan coryan requested a review from a team as a code owner February 18, 2022 16:51
@coryan coryan merged commit 3a69e34 into googleapis:main Feb 18, 2022
@coryan coryan deleted the feat-pubsub-per-call-options-in-topic-admin-client branch February 18, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants