Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): missing CMake dependency #8492

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 3, 2022

Fixes #8491

This change is Reviewable

@product-auto-label product-auto-label bot added the api: container Issues related to the Kubernetes Engine API API. label Mar 3, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: ca0d1fc5be4cdd2b2b58f10087329df1484bc16a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review March 3, 2022 04:15
@coryan coryan requested a review from a team as a code owner March 3, 2022 04:15
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8492 (ca0d1fc) into main (1b2e1fa) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8492   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files        1452     1452           
  Lines      125783   125783           
=======================================
+ Hits       118124   118128    +4     
+ Misses       7659     7655    -4     
Impacted Files Coverage Δ
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2e1fa...ca0d1fc. Read the comment docs.

@coryan coryan enabled auto-merge (squash) March 3, 2022 04:19
@coryan coryan merged commit 6d822f4 into googleapis:main Mar 3, 2022
@coryan coryan deleted the fix-container-missing-CMake-dependency branch March 3, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: container Issues related to the Kubernetes Engine API API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container does not build as a standalone service
3 participants