Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup!: restrict testing_util build visibility #8584

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Mar 23, 2022

Part of #3701

Change the default build visibility to private. Expose the previous targets as public but deprecated.


This change is Reviewable

@devjgm devjgm requested a review from a team as a code owner March 23, 2022 01:50
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: df5bf5fe309694efc45bcb22aacc5727886aaa12

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 9184767cfbf3457b23379f1e4a54aaa31ea99815

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #8584 (684ba69) into main (c7ffdec) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8584   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files        1462     1462           
  Lines      126954   126954           
=======================================
+ Hits       119210   119216    +6     
+ Misses       7744     7738    -6     
Impacted Files Coverage Δ
google/cloud/bigtable/internal/common_client.h 94.02% <0.00%> (-5.98%) ⬇️
...le/cloud/spanner/database_admin_connection_test.cc 99.70% <0.00%> (+0.29%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.75% <0.00%> (+0.49%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
google/cloud/spanner/database_admin_connection.cc 85.71% <0.00%> (+0.57%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ffdec...684ba69. Read the comment docs.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected these needed the *_internal + alias treatment too?

@devjgm
Copy link
Contributor Author

devjgm commented Mar 23, 2022

I would have expected these needed the *_internal + alias treatment too?

I can add that later today. I didn't bother originally because https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/testing_util/README.md says

The functions and types provided here are not intended for general use, and are subject to change without notice.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten that from the README, SGTM.

@devjgm
Copy link
Contributor Author

devjgm commented Mar 23, 2022

I had forgotten that from the README, SGTM.

Sorry, too late :-) Exposed publicly and deprecated. We can proceed either way with minimal effort. Do you have a preference how you'd like to proceed?

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: ad26d515da6df60377b2abc4276f876749b0fbb7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 684ba6934193de0cf388830689a6178a0f235fdd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 284f555949e2bb1b3d425c375c5afe25962ff92f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devjgm devjgm merged commit 61bf504 into googleapis:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants