-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup!: restrict testing_util build visibility #8584
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8584 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 1462 1462
Lines 126954 126954
=======================================
+ Hits 119210 119216 +6
+ Misses 7744 7738 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected these needed the *_internal
+ alias treatment too?
I can add that later today. I didn't bother originally because https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/testing_util/README.md says
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten that from the README, SGTM.
Sorry, too late :-) Exposed publicly and deprecated. We can proceed either way with minimal effort. Do you have a preference how you'd like to proceed? |
9184767
to
ad26d51
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
ad26d51
to
684ba69
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Part of googleapis#3701 These targets are documented as for internal use and subject to chagne without notice, so we should restrict their build visibility to reflect this fact. https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/testing_util/README.md
684ba69
to
284f555
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Part of #3701
Change the default build visibility to private. Expose the previous targets as public but deprecated.
This change is