fix(storage): avoid crashes when parsing ErrorInfo
#8968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe unsurprisingly, the error payloads are less structured that we expected. This PR performs additional validation to avoid crashes while trying to parse these payloads as a `ErrorInfo`. If we could reliably use exceptions I would just parse the code and handle any exception in a single line of code, alas, we cannot.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8968 +/- ##
==========================================
- Coverage 94.47% 94.47% -0.01%
==========================================
Files 1421 1421
Lines 124916 124931 +15
==========================================
+ Hits 118012 118024 +12
- Misses 6904 6907 +3
Continue to review full report at Codecov.
|
dbolduc
approved these changes
May 15, 2022
Comment on lines
+200
to
+201
| if (!e.contains("message") || !e.contains("details")) return default_error(); | ||
| if (!e["message"].is_string()) return default_error(); |
There was a problem hiding this comment.
We could return a Status(code, e.value("message", "")) if e.contains("message") && e["message"].is_string() && !e.contains("details"), but it's also fine to return the whole payload as a message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe unsurprisingly, the error payloads are less structured that we
expected. This PR performs additional validation to avoid crashes while
trying to parse these payloads as a
ErrorInfo. If we could reliablyuse exceptions I would just parse the code and handle any exception in
a single line of code, alas, we cannot.
Fixes #8965
This change is