Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use a CMake function to create pkg-config files #9018

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 19, 2022

All generated files, and most hand-crafted files, use
a common function to create and install the pkg-config(1) files.

Part of the work for #8992

The PR is broken down in several commits to (I hope) ease the review.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 150c1685976fdbc04fe03d6fcd1a6dd05361f0f6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 49aca6787b73753246ba00b5440c2c6882def668

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #9018 (49aca67) into main (83a81a0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9018      +/-   ##
==========================================
- Coverage   94.48%   94.47%   -0.01%     
==========================================
  Files        1422     1422              
  Lines      125254   125254              
==========================================
- Hits       118345   118336       -9     
- Misses       6909     6918       +9     
Impacted Files Coverage Δ
generator/internal/scaffold_generator.cc 84.32% <ø> (ø)
...le/cloud/storage/internal/curl_download_request.cc 88.25% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-1.00%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.97% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a81a0...49aca67. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 19, 2022 03:41
@coryan coryan requested a review from a team as a code owner May 19, 2022 03:41
Copy link
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is broken down in several commits to (I hope) ease the review.

Thanks.

@coryan coryan merged commit 7a451fc into googleapis:main May 19, 2022
@coryan coryan deleted the refactor-pkg-config-install-to-common-function branch May 19, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants