Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): helper functions for new lifecycle action #9028

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 19, 2022

A new helper function to avoid typos. Also add the snippet for this
feature.

Fixes #8690


This change is Reviewable

A new helper function to avoid typos. Also add the snippet for this
feature.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 19, 2022
@snippet-bot
Copy link

snippet-bot bot commented May 19, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 842d275a6be199637c42cf2cfe4171ea784f2283

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #9028 (842d275) into main (269a173) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9028      +/-   ##
==========================================
- Coverage   94.47%   94.47%   -0.01%     
==========================================
  Files        1421     1421              
  Lines      125201   125222      +21     
==========================================
+ Hits       118288   118307      +19     
- Misses       6913     6915       +2     
Impacted Files Coverage Δ
google/cloud/storage/lifecycle_rule.h 99.00% <ø> (ø)
...e/examples/storage_lifecycle_management_samples.cc 94.89% <100.00%> (+1.22%) ⬆️
google/cloud/storage/lifecycle_rule.cc 100.00% <100.00%> (ø)
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269a173...842d275. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 19, 2022 17:43
@coryan coryan requested a review from a team as a code owner May 19, 2022 17:43
@coryan
Copy link
Contributor Author

coryan commented May 19, 2022

/FYI: @BrennaEpp @shaffeeullah

@shaffeeullah
Copy link
Contributor

Looks good! Thanks @coryan ! Note we're not officially supporting samples for this, but doesn't hurt to have it.

@coryan coryan merged commit 143589e into googleapis:main May 19, 2022
@coryan coryan deleted the feat-storage-abort-multipart-upload-olm branch May 19, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: support AbortIncompleteMultipartUpload LifecycleAction
4 participants