Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): per-operation options / Notification #9205

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 8, 2022

Support per-operation google::cloud::Options for operations related to
Notification resources.

Part of the work for #7691


This change is Reviewable

Support per-operation `google::cloud::Options` for operations related to
`Notification` resources.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 8, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d81cfa88be611ddc9de57477a3aa9180bcf9a092

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #9205 (d81cfa8) into main (e6c39c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9205      +/-   ##
==========================================
- Coverage   94.51%   94.51%   -0.01%     
==========================================
  Files        1452     1452              
  Lines      130219   130234      +15     
==========================================
+ Hits       123077   123089      +12     
- Misses       7142     7145       +3     
Impacted Files Coverage Δ
google/cloud/storage/client.h 99.82% <100.00%> (+<0.01%) ⬆️
google/cloud/storage/client_notifications_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
google/cloud/spanner/database_admin_connection.cc 85.14% <0.00%> (-0.58%) ⬇️
...le/cloud/spanner/database_admin_connection_test.cc 99.40% <0.00%> (-0.30%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.25% <0.00%> (+0.49%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c39c1...d81cfa8. Read the comment docs.

@coryan coryan marked this pull request as ready for review June 8, 2022 01:47
@coryan coryan requested a review from a team as a code owner June 8, 2022 01:47
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 0ada61b into googleapis:main Jun 8, 2022
@coryan coryan deleted the feat-storage-per-operation-options-pr4.4 branch June 8, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants