Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): implement per-batch compression #9270

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 13, 2022

New options to compress published messages before they are put on the
wire. This can reduce bandwidth usage.


This change is Reviewable

New options to compress published messages before they are put on the
wire.  This can reduce bandwidth usage.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 13, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jun 13, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: df78cef016efb821bf7a53a1fb017878a54c8684

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #9270 (c4ba1c3) into main (e61b6da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9270   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files        1462     1462           
  Lines      132540   132596   +56     
=======================================
+ Hits       125363   125421   +58     
+ Misses       7177     7175    -2     
Impacted Files Coverage Δ
google/cloud/pubsub/internal/default_batch_sink.cc 100.00% <100.00%> (ø)
...e/cloud/pubsub/internal/default_batch_sink_test.cc 97.33% <100.00%> (+0.78%) ⬆️
google/cloud/pubsub/internal/defaults.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/defaults_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/samples/samples.cc 92.18% <100.00%> (+0.21%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-0.25%) ⬇️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61b6da...c4ba1c3. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c4ba1c30e54343f5495eaa5147dac80da060e4dd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review June 13, 2022 17:01
@coryan coryan requested a review from a team as a code owner June 13, 2022 17:01
@coryan
Copy link
Contributor Author

coryan commented Jun 13, 2022

/FYI: @anguillanneuf

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan enabled auto-merge (squash) June 13, 2022 17:56
@coryan coryan merged commit e34c68e into googleapis:main Jun 13, 2022
@coryan coryan deleted the feat-pubsub-add-support-for-publish-with-compression branch June 13, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants